fix(professors): handle nationalId and phone aliases with trimming; update payment sms

components/professors/professorService.js

@@ -7,18 +7,27 @@ const EVENT_NAMES = require('../../constants/eventNames');
 const { parsePaginationAndSort, buildFilterQuery, calculateMeta } = require('../../utils/pagination');
 
 const createProfessor = async (data) => {
+  const payload = {
+    ...data,
+    name: String(data.name || '').trim(),
+    surname: String(data.surname || '').trim(),
+    nationalIdCode: String(data.nationalIdCode || data.nationalId || '').trim(),
+    phoneNumber: String(data.phoneNumber || data.phone || '').trim(),
+    email: data.email ? String(data.email).trim().toLowerCase() : undefined
+  };
+
   const existing = await Professor.findOne({
     $or: [
-      { nationalIdCode: data.nationalIdCode },
-      { phoneNumber: data.phoneNumber },
-      ...(data.email ? [{ email: data.email }] : [])
+      { nationalIdCode: payload.nationalIdCode },
+      { phoneNumber: payload.phoneNumber },
+      ...(payload.email ? [{ email: payload.email }] : [])
     ]
   });
   if (existing) {
     throw new AppError('PROFESSOR_ALREADY_EXISTS');
   }
 
-  const professor = await Professor.create(data);
+  const professor = await Professor.create(payload);
   eventEmitter.emit(EVENT_NAMES.PROFESSOR_CREATED, { professorId: professor._id, name: `${professor.name} ${professor.surname}` });
   return professor;
 };
@@ -50,7 +59,22 @@ const updateProfessor = async (id, updateData) => {
     throw new AppError('PROFESSOR_NOT_FOUND');
   }
 
-  Object.assign(professor, updateData);
+  const payload = { ...updateData };
+  if (payload.nationalIdCode !== undefined || payload.nationalId !== undefined) {
+    payload.nationalIdCode = String(payload.nationalIdCode || payload.nationalId || '').trim();
+    delete payload.nationalId;
+  }
+  if (payload.phoneNumber !== undefined || payload.phone !== undefined) {
+    payload.phoneNumber = String(payload.phoneNumber || payload.phone || '').trim();
+    delete payload.phone;
+  }
+  if (payload.name !== undefined) payload.name = String(payload.name).trim();
+  if (payload.surname !== undefined) payload.surname = String(payload.surname).trim();
+  if (payload.email !== undefined) {
+    payload.email = payload.email ? String(payload.email).trim().toLowerCase() : undefined;
+  }
+
+  Object.assign(professor, payload);
   await professor.save();
   return professor;
 };