fix(professors): handle nationalId and phone aliases with trimming; update payment sms

components/payments/paymentService.js

@@ -7,11 +7,10 @@ const eventEmitter = require('../../events/eventEmitter');
 const EVENT_NAMES = require('../../constants/eventNames');
 const { calculateMeta, escapeRegex, getSearchTerm } = require('../../utils/pagination');
 const User = require('../users/userModel');
-const { sendInvoiceCreatedSms } = require('../../utils/senders/smsMessages');
-const logger = require('../../utils/logger');
-
 const Course = require('../courses/courseModel');
 const Class = require('../classes/classModel');
+const { sendInvoiceCreatedSms } = require('../../utils/senders/smsMessages');
+const logger = require('../../utils/logger');
 
 const getAllPayments = async (query) => {
   const page = parseInt(query.page) || 1;
@@ -81,17 +80,21 @@ const createPayment = async (body, actorId = null) => {
     if (user?.phoneNumber) {
       let courseName = '';
       if (payment.course) {
-        const courseDoc = await Course.findById(payment.course).select('title').lean();
-        courseName = courseDoc?.title || '';
+        const course = await Course.findById(payment.course).select('title').lean();
+        if (course?.title) courseName = course.title;
       } else if (payment.classes && payment.classes.length > 0) {
-        const classDoc = await Class.findById(payment.classes[0]).select('name').lean();
-        courseName = classDoc?.name || '';
+        const cls = await Class.findById(payment.classes[0]).populate('course', 'title').lean();
+        if (cls?.course?.title) {
+          courseName = cls.course.title;
+        } else if (cls?.name) {
+          courseName = cls.name;
+        }
       }
 
       await sendInvoiceCreatedSms(user.phoneNumber, {
         fullName: user.name || '',
         amount: payment.amount,
-        course: courseName
+        course: courseName || '-'
       }, user._id);
     }
   } catch (err) {